Call the flush method every time a Printer instance is called #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rytime it prints)
|
@nerdvegas I'm wondering if we could get this merged soon-ish? I'd like to get rid of this one line from our fork... Thanks! |
|
Ok, I'll do another round of low-hanging PRs soon. Larger PRs are still on
the radar, just have to get to them. Working on some things related to the
new package copy functionality presently.
Thx
A
…On Tue, Jan 22, 2019 at 8:42 AM JeanChristopheMorinRodeoFX < ***@***.***> wrote:
@nerdvegas <https://github.com/nerdvegas> I'm wondering if we could get
this merged soon-ish? I'd like to get rid of this one line from our fork...
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#540 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABjqSuu7NyhdxBOTA90bO6YO-WUVinvjks5vFjRggaJpZM4YXRh7>
.
|
|
Great! Let me know if you need some help on some stuff, like code review, or anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really really simple PR.
Logs printed with
rez.utils.colorize.Printerare being buffered for too long and it's causing the logs to be unordered in multiple cases (simply withrez-env -- some commands 1> /tmp/fileor under Jenkins).So I'm just flushing the buffer given to Printer every time it prints.