Fix TypeError when running get_rpaths on rez.utils.elf module #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzette
force-pushed
the
issue-1797-fix-bundle-error
branch
2 times, most recently
from
afb6c49 to
351bb0e
Compare
Signed-off-by: Ruzette Krukkert <ruzettekrukkert@fusefx.com>
ruzette
force-pushed
the
issue-1797-fix-bundle-error
branch
from
351bb0e to
ba17e02
Compare
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
+ Coverage 58.39% 58.52% +0.12%
==========================================
Files 126 126
Lines 17205 17206 +1
Branches 3519 3519
==========================================
+ Hits 10047 10069 +22
+ Misses 6491 6468 -23
- Partials 667 669 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Thank you @ruzette! I pushed some commits to fix the tests and make them more robust.
JeanChristopheMorinPerso
merged commit 3d0f224
into
AcademySoftwareFoundation:main
47 checks passed
Pixel-Minions
added a commit
to Pixel-Minions/rez
that referenced
this pull request
Sep 26, 2024
…ySoftwareFoundation#1798) Signed-off-by: Ruzette Krukkert <ruzettekrukkert@fusefx.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the subprocess.Popen with rez.utils.execution.Popen and added
text=Trueto fix the TypeError when reading and parsing rpathsCloses #1797