-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Windows registry queries to use winreg
module
#1780
Convert Windows registry queries to use winreg
module
#1780
Conversation
Signed-off-by: Nathan Rusch <nathan.rusch@scanlinevfx.com>
|
This may also fix #1467 |
Hi @nrusch , thanks for submitting this PR. We require all contributors to sign a CLA. You can look at the comment above from EasyCLA (#1780 (comment)) and follow the instructions. Let us know if you hit any problems. |
Yes, I'm aware of the CLA requirement. We are working on getting our Netflix corporate CLA working, so I'm waiting for a follow-up from people higher up the chain. |
OK, the CLA should be resolved now. |
Hi @nrusch thanks for this PR, we're also really interested in having this merged ! Now using |
Thank you @samson-jerome for the great feedback and trying it out! We are planning on merging this before our next release, which should hopefully happen in the next 2-3 weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you!
eb0e920
into
AcademySoftwareFoundation:main
Python 3 adds a
winreg
module to the standard library to perform Windows registry queries using native APIs.This change converts the rez registry queries to use the
winreg
API instead of executingcmd.exe
and/orpowershell
and parsing their output.