-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Powershell alias return correct exit codes #1778
Powershell alias return correct exit codes #1778
Conversation
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
… a process as they both seem to miss certain circumstances Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
a20d7de
to
fcc4b38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 58.41% 58.40% -0.01%
==========================================
Files 126 126
Lines 17163 17165 +2
Branches 3506 3506
==========================================
+ Hits 10025 10026 +1
- Misses 6473 6474 +1
Partials 665 665 ☔ View full report in Codecov by Sentry. |
Looks like Python isn't installed to all of our action VMs? Not sure what other command I could use that's shell agnostic outside of |
@brycegbrazen these tests are complex, so reuse what's already there and don't call python directly. Look at the |
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> Signed-off-by: Bryce Gattis <69012021+brycegbrazen@users.noreply.github.com>
63326f2
into
AcademySoftwareFoundation:main
…areFoundation#1778) Fixes issue where powershell plugins were not correctly capturing exit codes when aliased commands failed (AcademySoftwareFoundation#1778) --------- Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com> Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
Fixes issue where powershell plugins were not correctly capturing exit codes when aliased commands failed.
Closes #1776.