-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new default_build_process setting to set the default build process #1724
Add new default_build_process setting to set the default build process #1724
Conversation
Signed-off-by: predat <sylvain@predat.fr>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1724 +/- ##
==========================================
+ Coverage 58.29% 58.40% +0.11%
==========================================
Files 126 126
Lines 17159 17165 +6
Branches 3505 3506 +1
==========================================
+ Hits 10002 10026 +24
+ Misses 6493 6474 -19
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never realized we couldn't configure the default process! I think I'm ok with the idea of setting a default like this. I left some opened questions.
src/rez/rezconfig.py
Outdated
@@ -948,6 +948,9 @@ | |||
# launched without extension from windows and other systems. | |||
create_executable_script_mode = "single" | |||
|
|||
# Default build process to use during build/release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the valid values be documented? We could also make a link to --process
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a small comment on the build processes currently available.
Signed-off-by: predat <sylvain@predat.fr>
Signed-off-by: predat <sylvain@predat.fr>
Signed-off-by: predat <sylvain@predat.fr>
This PR is trivial; do you think you can merge it ? |
Sorry for the delays on this. It looks good to me! |
9094b08
into
AcademySoftwareFoundation:main
AcademySoftwareFoundation#1724) Signed-off-by: predat <sylvain@predat.fr>
This PR allows the user to define the name of the build process plugin to be used for build/release by defining it in the rezconfig or through an environment variable without having to specify it from the rez-build/rez-release command line tools.