Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new default_build_process setting to set the default build process #1724

Conversation

predat
Copy link
Contributor

@predat predat commented Apr 15, 2024

This PR allows the user to define the name of the build process plugin to be used for build/release by defining it in the rezconfig or through an environment variable without having to specify it from the rez-build/rez-release command line tools.

Signed-off-by: predat <sylvain@predat.fr>
@predat predat requested a review from a team as a code owner April 15, 2024 11:10
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.40%. Comparing base (36e0537) to head (3e5d178).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/rezconfig.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
+ Coverage   58.29%   58.40%   +0.11%     
==========================================
  Files         126      126              
  Lines       17159    17165       +6     
  Branches     3505     3506       +1     
==========================================
+ Hits        10002    10026      +24     
+ Misses       6493     6474      -19     
- Partials      664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never realized we couldn't configure the default process! I think I'm ok with the idea of setting a default like this. I left some opened questions.

@@ -948,6 +948,9 @@
# launched without extension from windows and other systems.
create_executable_script_mode = "single"

# Default build process to use during build/release

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the valid values be documented? We could also make a link to --process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a small comment on the build processes currently available.

src/rez/rezconfig.py Outdated Show resolved Hide resolved
predat added 3 commits May 22, 2024 10:27
Signed-off-by: predat <sylvain@predat.fr>
Signed-off-by: predat <sylvain@predat.fr>
Signed-off-by: predat <sylvain@predat.fr>
@predat
Copy link
Contributor Author

predat commented May 30, 2024

This PR is trivial; do you think you can merge it ?

@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Set default build process type in rezconfig or env var. Add new default_build_process setting to set the default build process Jun 22, 2024
@JeanChristopheMorinPerso
Copy link
Member

Sorry for the delays on this. It looks good to me!

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 9094b08 into AcademySoftwareFoundation:main Jun 22, 2024
46 of 47 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Jun 22, 2024
Pixel-Minions added a commit to Pixel-Minions/rez that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants