Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gh-rez external link dynamic #1707

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Make gh-rez external link dynamic #1707

merged 1 commit into from
Apr 13, 2024

Conversation

BryceGattis
Copy link
Contributor

Closes #1690. Applies suggested fix from @JeanChristopheMorinPerso.

@BryceGattis
Make gh-rez external link dynamic
0da32a3 
Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>
@BryceGattis BryceGattis requested a review from a team as a code owner April 3, 2024 02:53
@BryceGattis
Copy link
Contributor Author

@JeanChristopheMorinPerso Question though: This change only affects the URL in the PR right? It seems to still point just to 'main' when I do a local Sphinx build. Might be something nice to note as a comment if so.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Apr 7, 2024
@JeanChristopheMorinPerso
Copy link
Member

@BryceGattis do you think we should use file://... when not building on RTD and if the CI environment is not set? (CI is a commonly set environment variable by most CI systems).

@BryceGattis
Copy link
Contributor Author

@JeanChristopheMorinPerso

The READTHEDOCS environment variable is only set when we push to GitHub right? Just confirming.

I'm unsure exactly what I would need to put in the config file going down the file://... approach as you mentioned.

JeanChristopheMorinPerso
JeanChristopheMorinPerso approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go with this and change later if needed.

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit c5b2a61 into AcademySoftwareFoundation:main Apr 13, 2024
7 checks passed
Pixel-Minions added a commit to Pixel-Minions/rez that referenced this pull request Sep 26, 2024
@Pixel-Minions
Make gh-rez external link dynamic in the documentation (AcademySoftwa…
4cd6fe9 
…reFoundation#1707)

Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanChristopheMorinPerso JeanChristopheMorinPerso JeanChristopheMorinPerso approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

Change gh-rez URL based on source of build
2 participants
@BryceGattis @JeanChristopheMorinPerso