Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic versioning warning #1614

Conversation

brycegbrazen
Copy link
Contributor

Add semantic versioning ordering warning based on this Slack discussion last month.

This adds a clear note that semantic version ordering differs from Rez version ordering.

Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
@@ -81,6 +81,13 @@ version than ``1.0``.
a version number doesn't matter, you can have as many as you like. While you are encouraged to use
semantic versioning (see `<https://semver.org>`_), it is not enforced.

.. note::
If you are using semantic versioning, please note that version ordering will NOT behave like described

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is already covered by the note above. Do you think we could rework the previous note to clarify it a little bit? For example, instead of saying "you are encouraged to use semver", we could say "you are encouraged to use a semver like scheme".

The note already says that alpha and beta have no meaning. Which leads me to think that the misleading part of the note is the last sentence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanChristopheMorinPerso Yeah I agree that reiterating that special terms having no meaning is redundant, so I'll remove that.
I think the big thing I wanted to add here is an explicit note that version ordering will not behave like it is described in sem ver. Let me know if this next commit feels better to you.

Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
@JeanChristopheMorinPerso
Copy link
Member

Thanks!

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 6bdba31 into AcademySoftwareFoundation:main Jan 27, 2024
5 checks passed
Pixel-Minions pushed a commit to Pixel-Minions/rez that referenced this pull request Feb 14, 2024
Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>
Signed-off-by: Jose Enriquez <jose.enriquez@barnstormvfx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants