Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1271 improve shell parameterization in tests #1272

Merged

Conversation

nerdvegas
Copy link
Contributor

For tests that iterate over shells, we now get this:

test_build.py::TestBuild::test_builds_0_csh PASSED                       [  2%]
test_build.py::TestBuild::test_builds_1_tcsh PASSED                      [  3%]
test_build.py::TestBuild::test_builds_2_sh PASSED                        [  3%]
test_build.py::TestBuild::test_builds_3_bash PASSED                      [  3%]

Instead of this:

# iteration happened and printed to stdout, but we can't see it
test_build.py::TestBuild::test_builds PASSED                       [  2%]

Fixes #1271

Uses https://pypi.org/project/parameterized (which worked first time, good stuff).

@nerdvegas nerdvegas linked an issue Apr 5, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nerdvegas nerdvegas merged commit ee17c39 into master Apr 7, 2022
@bpabel bpabel deleted the feature/1271-improve-shell-parameterization-in-tests branch January 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve shell parameterization in tests
1 participant