Issue 1032 pypi #1034
Merged
Issue 1032 pypi #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
March 2, 2021 13:47
-changed workflow names to exactly match yaml filename
j0yu
reviewed
Mar 3, 2021
| with: | ||
| name: wiki-markdown | ||
| path: ${{ env.TEMP_WIKI_DIR }} | ||
|
|
||
|
|
||
| publish: | ||
| name: Publish to GitHub Wiki | ||
| runs-on: ubuntu-latest | ||
| needs: build |
There was a problem hiding this comment.
Would it be possible to still keep the build and publish as separate jobs in the same workflow YAML file, but for the publish job, include an extra if to only run it during a release event?
on: # Merge in this at the top of file
release:
types: [released]
publish:
 name: Publish to GitHub Wiki
 runs-on: ubuntu-latest
if: github.event_name == 'release'
 needs: build
Comment on lines
+28
to
+33
| - name: Upload to PyPi | ||
| run: | | ||
| python -m twine upload dist/* | ||
| env: | ||
| TWINE_USERNAME: '${{ secrets.PYPI_USERNAME }}' | ||
| TWINE_PASSWORD: '${{ secrets.PYPI_PASSWORD }}' |
There was a problem hiding this comment.
I've spotted pypa have setup a CI action that could be used here to do the upload if you prefer instead of twine
|
Thanks for these suggestions Joe, I'll try them out now. Good idea RE the
wiki workflow.
A
…On Wed, Mar 3, 2021 at 12:28 PM Joe Yu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/wiki-publish.yaml
<#1034 (comment)>:
> with:
name: wiki-markdown
path: ${{ env.TEMP_WIKI_DIR }}
-
publish:
name: Publish to GitHub Wiki
runs-on: ubuntu-latest
needs: build
Would it be possible to still keep the build and publish as separate jobs
in the same workflow YAML file, but for the publish job, include an extra
if to only run it during a release event?
on: # Merge in this at the top of file
release:
types: [released]
publish:
 name: Publish to GitHub Wiki
 runs-on: ubuntu-latest
if: github.event_name == 'release'
 needs: build
------------------------------
In .github/workflows/pypi.yaml
<#1034 (comment)>:
> + - name: Upload to PyPi
+ run: |
+ python -m twine upload dist/*
+ env:
+ TWINE_USERNAME: '${{ secrets.PYPI_USERNAME }}'
+ TWINE_PASSWORD: '${{ secrets.PYPI_PASSWORD }}'
I've spotted pypa have setup a CI action
<https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#publishing-the-distribution-to-pypi-and-testpypi>
that could be used here to do the upload if you prefer instead of twine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1034 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOUSVSVDHTFTT3P6YJ6OTTBWGCFANCNFSM4YQACHEQ>
.
|
|
Winner, those changes are released.
…On Wed, Mar 3, 2021 at 12:32 PM Allan Johns ***@***.***> wrote:
Thanks for these suggestions Joe, I'll try them out now. Good idea RE the
wiki workflow.
A
On Wed, Mar 3, 2021 at 12:28 PM Joe Yu ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In .github/workflows/wiki-publish.yaml
> <#1034 (comment)>:
>
> > with:
>
> name: wiki-markdown
>
> path: ${{ env.TEMP_WIKI_DIR }}
>
>
>
> -
>
> publish:
>
> name: Publish to GitHub Wiki
>
> runs-on: ubuntu-latest
>
> needs: build
>
>
> Would it be possible to still keep the build and publish as separate jobs
> in the same workflow YAML file, but for the publish job, include an
> extra if to only run it during a release event?
>
> on: # Merge in this at the top of file
>
> release:
>
> types: [released]
>
>
>
>
>
> publish:
>  name: Publish to GitHub Wiki
>  runs-on: ubuntu-latest
>
> if: github.event_name == 'release'
>  needs: build
>
> ------------------------------
>
> In .github/workflows/pypi.yaml
> <#1034 (comment)>:
>
> > + - name: Upload to PyPi
>
> + run: |
>
> + python -m twine upload dist/*
>
> + env:
>
> + TWINE_USERNAME: '${{ secrets.PYPI_USERNAME }}'
>
> + TWINE_PASSWORD: '${{ secrets.PYPI_PASSWORD }}'
>
>
> I've spotted pypa have setup a CI action
> <https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#publishing-the-distribution-to-pypi-and-testpypi>
> that could be used here to do the upload if you prefer instead of twine
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1034 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAMOUSVSVDHTFTT3P6YJ6OTTBWGCFANCNFSM4YQACHEQ>
> .
>
|
|
awesome, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1032
Also changed the wiki workflow a little by splitting into build/publish workflows.