Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial removal of all Imath source files and minimal cmake adjustments #791

Merged
merged 5 commits into from
Jul 21, 2020

Conversation

oxt3479
Copy link
Contributor

@oxt3479 oxt3479 commented Jul 17, 2020

This PR will do the 'bare minimum' of removing Imath.
No source is moved from the IlmBase directory. Merely all Imath is removed. Even Iex is kept in.

Installation works on linux provided you have installed Imath beforehand. Currently it looks for Imath with the same version number as OpenEXR, currently set and working with imath_2_5. This can be changed in the future if necessary.

Further changes are going to be made but having this baseline may prove to be useful.

Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
IlmBase/CMakeLists.txt Outdated Show resolved Hide resolved
@xlietz
Copy link
Contributor

xlietz commented Jul 17, 2020

You may have seen but in case you didn't - this is generating an error in the CI configuration step:

-- Configure ILMBASE Version: 2.5.2 Lib API: 25.0.1
CMake Warning at IlmBase/CMakeLists.txt:26 (find_package):
By not providing "FindImath.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Imath", but
CMake did not find one.

Could not find a package configuration file provided by "Imath" with any of
the following names:

ImathConfig.cmake
imath-config.cmake

Add the installation prefix of "Imath" to CMAKE_PREFIX_PATH or set
"Imath_DIR" to a directory containing one of the above files. If "Imath"
provides a separate development package or SDK, be sure it has been
installed.

…lled.

Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
@cary-ilm cary-ilm merged commit 5dd844c into AcademySoftwareFoundation:RC-3 Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants