Disable OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVX when building on arm64 macOS #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
For some reason, the compile check for detecting inline AVX support does not correctly disable OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVX when building on arm64 macOS using clang (the check does work correctly on aarch64 Linux using gcc). This change hardcodes OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVX to always be false when the system is detected as arm64 macOS. This change is necessary to allow building on arm64 macOS to complete successfully. Signed-off-by: Yining Karl Li <betajippity@gmail.com>
9 tasks
|
@betajippity Could you do the DCO thing? I believe you have to amend the commit with some boilerplate. |
|
@meshula I thought I already did the DCO thing? Or do I have to do it again? |
|
Must have been an automation glitch! Everything is green now :) |
|
But.. what if you are building for multiple architectures? I may be confused, my cmake knowledge is low and after running cmake we build in Xcode, but this fix would appear to disable AVX only if building arm64 only? (My dirty fix is adding |
This was referenced Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the compile check for detecting inline AVX support does
not correctly disable OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVX when building
on arm64 macOS using clang (the check does work correctly on aarch64 Linux
using gcc). This change hardcodes OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVX to
always be false when the system is detected as arm64 macOS. This change
is necessary to allow building on arm64 macOS to complete successfully.