Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boost::Python to Python modules link libraries #596

Merged

Conversation

JenusL
Copy link
Contributor

@JenusL JenusL commented Oct 21, 2019

Small patch that adds the missing Boost linking to the python modules PyIex and PyImath
This closes #573 and closes #594

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, @antonio-rojas, can you verify whether this fixes your issue?

@JenusL
Copy link
Contributor Author

JenusL commented Oct 22, 2019

I'm building on Windows 10 with CMake 3.15.4, Visual Studio 2019, MSVC 14.00.
First I open a dev console: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\Tools\VsDevCmd.bat" -arch=amd64 -host_arch=amd64 -winsdk=10.0.18362.0 -vcvars_ver=14.0
Then I generate with cmake -G "Visual Studio 16 2019" -T v140 and then build.

Without the patch, the generated iex_python2.vcxproj and imath_python2.vcxproj wouldn't get boost_python3-vc140-mt-x64-1_70.lib added to additional dependencies.

@xlietz
Copy link
Contributor

xlietz commented Oct 22, 2019

@meshula I think you may have noticed already, our CI isn't finding boost or boost python on Windows, still on my to-do list. The CI still doesn't find it with this change, but if it works for @JenusL that's a good start. @kdt3rd ?

@JenusL
Copy link
Contributor Author

JenusL commented Oct 22, 2019

I had a look at the CI logs for this PR and when Boost is being built it sets BOOST_ROOT = c:\Program Files\Boost\1.66.0
But then in the OpenEXR build I can see this in the log:

Environment variable Boost_ROOT is set to:

    C:\Program Files\Boost\1.69.0

Boost 1.69.0 is never being built and I don't know where it got that version number from. But I would start the investigation there.

@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Oct 24, 2019
@cary-ilm cary-ilm merged commit c1c82f7 into AcademySoftwareFoundation:master Oct 24, 2019
@cary-ilm cary-ilm added this to the v2.4.1 milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion To be discussed in the technical steering committee
Projects
None yet
4 participants