Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes for SonarCloud bugs #578

Merged
merged 2 commits into from
Oct 8, 2019
Merged

More fixes for SonarCloud bugs #578

merged 2 commits into from
Oct 8, 2019

Conversation

xlietz
Copy link
Contributor

@xlietz xlietz commented Oct 7, 2019

SonarCloud bug fixes:

  • suppress warnings for PyBind defs
  • change nan check from 'a!=a' to std::isnan() and add infinity checks

@xlietz
Change 'a!=a' to std::isnan() to fix Sonar "bug", added infinity checks
83b5fcf 
Signed-off-by: Christina Tempelaar-Lietz <xlietz@gmail.com>
@xlietz
More NOSONAR suppressions in PyImath.
0a2cfaf 
Signed-off-by: Christina Tempelaar-Lietz <xlietz@gmail.com>
cary-ilm
cary-ilm approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xlietz xlietz merged commit a2a133a into AcademySoftwareFoundation:master Oct 8, 2019
@xlietz xlietz deleted the sonar-fixes branch October 8, 2019 06:39
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees
No one assigned
Labels
v2.5.0
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xlietz @cary-ilm