Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NOSONAR comments to PyImath to suppress "self==self" bug reports. #558

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Add NOSONAR comments to PyImath to suppress "self==self" bug reports. #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions PyIlmBase/PyImath/PyImathBox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ register_Box2()
.def_readwrite("max",&Box<T>::max)
.def("min", &boxMin<T>)
.def("max", &boxMax<T>)
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__repr__", &Box2_repr<T>)
.def("makeEmpty",&Box<T>::makeEmpty,"makeEmpty() make the box empty")
.def("makeInfinite",&Box<T>::makeInfinite,"makeInfinite() make the box cover all space")
Expand Down Expand Up @@ -416,8 +416,8 @@ register_Box3()
.def("__init__", make_constructor(boxConstructor<T, IMATH_NAMESPACE::V3i>))
.def_readwrite("min",&Box<T>::min)
.def_readwrite("max",&Box<T>::max)
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__mul__", &mulM44<T, float>)
.def("__mul__", &mulM44<T, double>)
.def("__imul__", &imulM44<T, float>,return_internal_reference<>())
Expand Down
4 changes: 2 additions & 2 deletions PyIlmBase/PyImath/PyImathColor3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,8 +593,8 @@ register_Color3()
.def_readwrite("b", &Color3<T>::z)
.def("__str__", &color3_str<T>)
.def("__repr__", &color3_repr<T>)
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__iadd__", &iadd<T>,return_internal_reference<>())
.def("__add__", &add<T>)
.def("__add__", &addTuple<T>)
Expand Down
4 changes: 2 additions & 2 deletions PyIlmBase/PyImath/PyImathColor4.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,8 @@ register_Color4()
.def_readwrite("a", &Color4<T>::a)
.def("__str__", &color4_str<T>)
.def("__repr__", &color4_repr<T>)
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__iadd__", &iadd<T>,return_internal_reference<>())
.def("__add__", &add<T>)
.def("__add__", &addTuple<T>)
Expand Down
4 changes: 2 additions & 2 deletions PyIlmBase/PyImath/PyImathFrustum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,8 @@ register_Frustum()
.def(init<>("Frustum() default construction"))
.def(init<T,T,T,T,T,T,bool>("Frustum(nearPlane,farPlane,left,right,top,bottom,ortho) construction"))
.def(init<T,T,T,T,T>("Frustum(nearPlane,farPlane,fovx,fovy,aspect) construction"))
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__repr__",&Frustum_repr<T>)
.def("set", set1,
"F.set(nearPlane, farPlane, left, right, top, bottom, "
Expand Down
4 changes: 2 additions & 2 deletions PyIlmBase/PyImath/PyImathMatrix33.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,8 +905,8 @@ register_Matrix33()
.def("minorOf",&Matrix33<T>::minorOf,"minorOf() return the matrix minor of the (row,col) element of this matrix")
.def("fastMinor",&Matrix33<T>::fastMinor,"fastMinor() return the matrix minor using the specified rows and columns of this matrix")
.def("determinant",&Matrix33<T>::determinant,"determinant() return the determinant of this matrix")
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__iadd__", &iadd33<T, float>,return_internal_reference<>())
.def("__iadd__", &iadd33<T, double>,return_internal_reference<>())
.def("__iadd__", &iadd33T<T>,return_internal_reference<>())
Expand Down
4 changes: 2 additions & 2 deletions PyIlmBase/PyImath/PyImathMatrix44.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,8 +1004,8 @@ register_Matrix44()
.def("inverse",&inverse44<T>,inverse44_overloads("inverse() return a inverted copy of this matrix"))
.def("gjInvert",&gjInvert44<T>,gjInvert44_overloads("gjInvert() invert this matrix")[return_internal_reference<>()])
.def("gjInverse",&gjInverse44<T>,gjInverse44_overloads("gjInverse() return a inverted copy of this matrix"))
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__iadd__", &iadd44<T, float>,return_internal_reference<>())
.def("__iadd__", &iadd44<T, double>,return_internal_reference<>())
.def("__iadd__", &iadd44T<T>,return_internal_reference<>())
Expand Down
4 changes: 2 additions & 2 deletions PyIlmBase/PyImath/PyImathQuat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ register_Quat()
.def ("__itruediv__", &idivT<T>, return_internal_reference<>())
.def ("__iadd__", &iadd<T>, return_internal_reference<>())
.def ("__isub__", &isub<T>, return_internal_reference<>())
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def ("__rmul__", &rmulM33<T>)
.def ("__mul__", &mulM33<T>)
.def ("__mul__", &mul<T>)
Expand Down
4 changes: 2 additions & 2 deletions PyIlmBase/PyImath/PyImathShear.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,8 +533,8 @@ register_Shear()
.def("__div__",&divT<T>)
.def("__truediv__",&div<T>)
.def("__truediv__",&divT<T>)
.def(self == self)
.def(self != self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def("__str__",&Shear_str<T>)
.def("__repr__",&Shear_repr<T>)
.def("setValue", setValue1)
Expand Down
8 changes: 4 additions & 4 deletions PyIlmBase/PyImath/PyImathStringArray.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,10 @@ void register_StringArrays()
.def("__setitem__", &StringArray::setitem_string_vector)
.def("__setitem__", &StringArray::setitem_string_vector_mask)
.def("__len__",&StringArray::len)
.def(self == self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self == other<std::string>())
.def(other<std::string>() == self)
.def(self != self)
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def(self != other<std::string>())
.def(other<std::string>() != self)
;
Expand All @@ -324,10 +324,10 @@ void register_StringArrays()
.def("__setitem__", &WstringArray::setitem_string_vector)
.def("__setitem__", &WstringArray::setitem_string_vector_mask)
.def("__len__",&WstringArray::len)
.def(self == self)
.def(self == self) // NOSONAR - suppress SonarCloud bug report.
.def(self == other<std::wstring>())
.def(other<std::wstring>() == self)
.def(self != self)
.def(self != self) // NOSONAR - suppress SonarCloud bug report.
.def(self != other<std::wstring>())
.def(other<std::wstring>() != self)
;
Expand Down