Fix #246, add type traits check #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous cleanup did most of the work, but add an explicit test that half is now trivial and default constructible Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
cary-ilm
reviewed
Jul 23, 2019
|
The problem is that the template is C++11 but is only partially supported.
…On Tue, Jul 23, 2019 at 2:28 PM Kimball Thurston ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In IlmBase/HalfTest/testClassification.cpp
<#486 (comment)>:
>
using namespace std;
namespace {
+static_assert(std::is_trivially_default_constructible<half>::value, "half is trivial and default constructible");
yeah, well, how about "mostly" compliant? What we mostly decided to do is
to start removing the need to keep c++98 branches of the code alive.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#486>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFC3DGM3WT6D663PUJSFYSLQA5ZZFANCNFSM4IGCVVHA>
.
--
Cary Phillips | R&D Supervisor | ILM | San Francisco
|
|
Abseil has a workaround and details on the gcc issues here https://github.com/abseil/abseil-cpp/blob/master/absl/meta/type_traits.h starting at line 258. Maybe there's some hints on a solution there. |
…mpilers Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
|
I just am doing the check in c++14, which should require a compliant compiler, and is only a safety check anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous cleanup did most of the work, but add an explicit test that
half is now trivial and default constructible
Signed-off-by: Kimball Thurston kdt3rd@gmail.com