Fetch master branch of libdeflate on main #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than pinning libdeflate to a specific version, we should have the OpenEXR main branch fetch from libdeflate's master branch, so our bleeding edge uses their bleeding edge. Then, we pin to the most recent libdeflate branch on minor release, or patch release if it's ABI compatible. Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Works for me to address the issue Matt raised.
Tagging @Vertexwahn for a Bazel equivalent, if you've got a moment to look at it 🙏 (Perhaps the Bazel build might want to be explicitly linked to the last version OpenEXR released, so doesn't need a similar mechanism?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than pinning libdeflate to a specific version, we should have the OpenEXR main branch fetch from libdeflate's master branch, so our bleeding edge uses their bleeding edge. Then, we pin to the most recent libdeflate release on our minor release, or patch release if it's ABI compatible. Similar to what we do with Imath.