Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exact file match #1727

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Apr 20, 2024

This fixes the remaining issues with files not matching precisely core vs c++

C++ differentiated scanlines vs tiles in the DWAA compression type

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
This means all files saved c++ vs C match precisely, re-enable that
failure mode (had been behind an env variable)

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdt3rd kdt3rd merged commit 694606d into AcademySoftwareFoundation:main Apr 20, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants