Use component for python #1643
Merged
Use component for python #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it-build-core to only install the python component Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
cary-ilm
approved these changes
Feb 16, 2024
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2024
* Add "COMPONENT python" to install() the python bindings and tell scikit-build-core to only install the python component Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> * Update scikit-build-core to 0.8.1 Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> * Fix typo Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> --------- Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Add "COMPONENT python" to install() the python bindings and tell scikit-build-core to only install the python component Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> * Update scikit-build-core to 0.8.1 Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> * Fix typo Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> --------- Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While talking with the
scikit-build-coremaintainers, I learned that we can use cmake components to precisely select which files to install into wheels.What @cary-ilm did in #1487 was to instruct Imath to not be installed (https://github.com/AcademySoftwareFoundation/openexr/blob/main/cmake/OpenEXRSetup.cmake#L295). This works. But I think using components will future proof the process.