Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the Header class. #1577

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

MrGlobby
Copy link
Contributor

These are intended to exercise methods that are currently not covered by other tests according to the coverage report.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MrGlobby / name: Ben Grimes (4245a62)

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the test failure.

The CLA should be on the way shortly.

These are intended to exercise methods that are currently not covered by
other tests according to the coverage report.

Signed-off-by: Ben Grimes <bgrimes@ilm.com>
@cary-ilm
Copy link
Member

Thanks, I'm not sure what's up with the CLA., I was informed it was in place.

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cary-ilm cary-ilm merged commit fca936a into AcademySoftwareFoundation:main Oct 16, 2023
29 checks passed
annguyen-ilm pushed a commit to annguyen-ilm/openexr that referenced this pull request Oct 24, 2023
These are intended to exercise methods that are currently not covered by
other tests according to the coverage report.

Signed-off-by: Ben Grimes <bgrimes@ilm.com>
Signed-off-by: An Nguyen <annguyen@ilm.com>
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request Feb 13, 2024
These are intended to exercise methods that are currently not covered by
other tests according to the coverage report.

Signed-off-by: Ben Grimes <bgrimes@ilm.com>
cary-ilm pushed a commit that referenced this pull request Feb 16, 2024
These are intended to exercise methods that are currently not covered by
other tests according to the coverage report.

Signed-off-by: Ben Grimes <bgrimes@ilm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants