Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build of 2.5 branch with GCC 13 #1499

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

aumuell
Copy link

@aumuell aumuell commented Jul 29, 2023

explicitly including <cstdint> at three locations is sufficient

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 29, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aumuell / name: Martin Aumüller (8bb802a)

explictly include <cstdint>

Signed-off-by: Martin Aumüller <aumuell@reserv.at>
@aumuell aumuell changed the title fix build with GCC 13 fix build of 2.5 branch with GCC 13 Jul 29, 2023
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for confirming it fixes the issue you ran into!

@lgritz
Copy link
Contributor

lgritz commented Jul 29, 2023

Are we just merging this because why not, or are we considering a 2.5.x release? That's a branch that we don't claim to support and haven't updated (even for critical fixes) for a over 2 years.

@cary-ilm
Copy link
Member

@aumuell, do you have a specific need for a 2.5 patch release? We don't actively maintain 2.x releases, but if you do have a specific need we can discuss it.

@aumuell
Copy link
Author

aumuell commented Jul 30, 2023

The OpenEXR I/O plugin of OpenSceneGraph uses the version 2 API. And OpenSceneGraph does not seem to get updates any longer. This is why I built this old branch of OpenEXR.

@cary-ilm
Copy link
Member

That's fine, I'll merge the change and put out a new 2.5.9 release.

@cary-ilm cary-ilm merged commit 310ae86 into AcademySoftwareFoundation:RB-2.5 Jul 31, 2023
1 check passed
@cary-ilm
Copy link
Member

Done.

@aumuell
Copy link
Author

aumuell commented Jul 31, 2023

Thank you for applying this and the quick release!

@aumuell aumuell deleted the RB-2.5-gcc13 branch July 31, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants