-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cpu detection of sse2 on non-64 x86 #1467
Conversation
Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that. Fixes AcademySoftwareFoundation#1459 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
We require gcc / clang style inline asm for avx support, detecting it properly causes problems for the dwa support which uses that. Disable again. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should reduce the chance of introducing errors in the snarl in future maintenance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix cpu detection of sse2 on non-64 x86 Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that. Fixes AcademySoftwareFoundation#1459 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Fix mismatch with windows and enable avx support check there Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Disable avx detection under msvc for now We require gcc / clang style inline asm for avx support, detecting it properly causes problems for the dwa support which uses that. Disable again. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
* Fix cpu detection of sse2 on non-64 x86 Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that. Fixes #1459 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Fix mismatch with windows and enable avx support check there Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Disable avx detection under msvc for now We require gcc / clang style inline asm for avx support, detecting it properly causes problems for the dwa support which uses that. Disable again. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
This broke the build when compiling with |
Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that.
Fixes #1459