Fix gcc-11 warnings: signed/unsigned integer comparison, unused variables #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables Signed-off-by: Cary Phillips <cary@ilm.com>
|
@kdt3rd, @meshula, @peterhillman, @lgritz, these seem fairly benign, but I'd still like some other eyes on it, can someone look it over? |
meshula
reviewed
Jun 30, 2023
Comment on lines
229
to
231
| for (int i = 0; i < 65536; ++i) | ||
| { | ||
| unsigned short src = (unsigned short) i; | ||
| assert (src == OPENEXR_IMF_INTERNAL_NAMESPACE::dwaCompressorNoOp[i]); | ||
| assert ((unsigned short) i == OPENEXR_IMF_INTERNAL_NAMESPACE::dwaCompressorNoOp[i]); |
There was a problem hiding this comment.
Should probably just make the loop
for (unsigned short i = 0; ...)
then there's no casting at all
meshula
requested changes
Jun 30, 2023
| @@ -53,12 +53,12 @@ failable_malloc (size_t bytes) | |||
| return malloc (bytes); | |||
| } | |||
|
|
|||
| static void | |||
| failable_free (void* p) | |||
There was a problem hiding this comment.
down below we assign failable_alloc within cinit.
I'm pretty sure the intent was failable_free be correspondingly assigned within cinit as well.
There was a problem hiding this comment.
Adding the assignment to free_fn:
static exr_context_t
createDummyFile (const char* test)
{
exr_context_t f = NULL;
exr_context_initializer_t cinit = EXR_DEFAULT_CONTEXT_INITIALIZER;
// we won't actually write to this and so don't need a proper
// stream but need a writable context to test with.
cinit.write_fn = dummy_write;
cinit.alloc_fn = failable_malloc;
cinit.free_fn = failable_free;
causes OpenEXRCore.testAttrChlists and OpenEXRCore.testAttrLists to fail, so something needs some further attention. I'll leave the free function in for now.
There was a problem hiding this comment.
Gotcha, can we add
// adding failable_malloc currently causes OpenEXRCore.testAttrChlists and OpenEXRCore.testAttrLists to fail.
// commented out until we've investigated.
//cinit.free_fn = failable_free;With that I think we're good to land this
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Jul 3, 2023
Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Jul 25, 2023
…bles (AcademySoftwareFoundation#1463) * Fix gcc-11 warnings: signed/unsigned integer comparision, unused variables Signed-off-by: Cary Phillips <cary@ilm.com> * declare loop variable i as unsigned int Signed-off-by: Cary Phillips <cary@ilm.com> * uncomment-out failable_free Signed-off-by: Cary Phillips <cary@ilm.com> * add commented-out assignment of failable_free as TODO Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Jul 31, 2023
…bles (#1463) * Fix gcc-11 warnings: signed/unsigned integer comparision, unused variables Signed-off-by: Cary Phillips <cary@ilm.com> * declare loop variable i as unsigned int Signed-off-by: Cary Phillips <cary@ilm.com> * uncomment-out failable_free Signed-off-by: Cary Phillips <cary@ilm.com> * add commented-out assignment of failable_free as TODO Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.