Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel support: Switch back to VS2019 due to a toolchain issue in Bazel #1457

Merged

Conversation

Vertexwahn
Copy link
Contributor

This change only affects the Bazel build in the CI and makes the CI green again.

Because of an update of Visual Studio the Bazel Windows Build is failing - more details here: bazelbuild/bazel#18592

One workaround is to use VS 2019 for now, until this is fixed.

Another option would be to modify the directory of VS2022.

Once this is fixed the Bazel Windows CI build will switch back to VS2022.

Signed-off-by: Vertexwahn <julian.amann@tum.de>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cary-ilm cary-ilm merged commit e504fb2 into AcademySoftwareFoundation:main Jun 16, 2023
cary-ilm pushed a commit that referenced this pull request Jun 23, 2023
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jul 6, 2023
## Version 3.1.9 (June 25, 2023)

Patch release that addresses miscelleneous build and doc issues, as well as:

* OSS-fuzz [59382](https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59382)
  Heap-buffer-overflow in internal_huf_decompress

### Merged Pull Requests

* [1461](https::/github.com/AcademySoftwareFoundation/openexr/pull/1461)
  don't use NaNs/infs in testOptimizedInterleavePatterns
* [1457](https::/github.com/AcademySoftwareFoundation/openexr/pull/1457)
  Bazel support: Switch back to VS2019 due to a toolchain issue in Bazel
* [1454](https::/github.com/AcademySoftwareFoundation/openexr/pull/1454)
  Add ``OPENEXR_IMF_INTERNAL_NAMESPACE`` for ``WidenFilename``
* [1452](https::/github.com/AcademySoftwareFoundation/openexr/pull/1452)
  Use ``security@openexr.com`` for consistency
* [1448](https::/github.com/AcademySoftwareFoundation/openexr/pull/1448)
  compression.cpp: fix isnan
* [1443](https::/github.com/AcademySoftwareFoundation/openexr/pull/1443)
  Bazel bump imath
* [1439](https::/github.com/AcademySoftwareFoundation/openexr/pull/1439)
  Fix scenario where malformed dwa file could read past end of buffer
* [1416](https::/github.com/AcademySoftwareFoundation/openexr/pull/1416)
  IlmThread: fix defines for older macOS: do not prefix with ``__``
@cary-ilm cary-ilm added the v3.1.9 label Jul 9, 2023
@Vertexwahn Vertexwahn deleted the fix-bazel-toolchain-issue branch September 16, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants