Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of builddir and cxxwarns in clang_coverage.sh #1427

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix handling of builddir and cxxwarns in clang_coverage.sh #1427

merged 1 commit into from
May 22, 2023

Conversation

cary-ilm
Copy link
Member

Also, some ='s appeared to be missing on the -ignore-filename-regex lines

@cary-ilm
Fix handling of builddir and cxxwarns in clang_coverage.sh
829a655 
Also, some ='s appeared to be missing on the -ignore-filename-regex lines

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm cary-ilm requested a review from kdt3rd May 22, 2023 06:12
kdt3rd
kdt3rd approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@kdt3rd kdt3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not sure the = are even necessary, but most have not regenerated the build folder after I refactored for better understandability, so those changes are great.

@cary-ilm cary-ilm merged commit 2006139 into AcademySoftwareFoundation:main May 22, 2023
@cary-ilm cary-ilm added the v3.2.0 label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdt3rd kdt3rd kdt3rd approved these changes

Assignees
No one assigned
Labels
v3.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cary-ilm @kdt3rd