Fix MSVC Debug build with internal zlib #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlib sets CMAKE_DEBUG_POSTFIX to "d" with msvc in debug Signed-off-by: Mark Reid <mindmark@gmail.com>
|
|
meshula
approved these changes
Dec 18, 2022
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
zlib sets CMAKE_DEBUG_POSTFIX to "d" with msvc in debug Signed-off-by: Mark Reid <mindmark@gmail.com> Signed-off-by: Mark Reid <mindmark@gmail.com>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
zlib sets CMAKE_DEBUG_POSTFIX to "d" with msvc in debug Signed-off-by: Mark Reid <mindmark@gmail.com> Signed-off-by: Mark Reid <mindmark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this issue when trying to build in debug mode with msvc and it not being able to link to the internal zlib.
To replicate in a MSVC Developer command prompt and a clean build dir run
I get this error
zlib's cmake script is setting
CMAKE_DEBUG_POSTFIXto "d" with msvc. The lib name should bezlibstaticd.libin debug. The current scripts don't take the "d" into account.There might be a better way fix this. I couldn't figure out a way in cmake to override this behavior without modifying zlib. I ended up going with setting the additional
IMPORTED_LOCATION_DEBUGproperty instead. I also tried those fancy generator expressions but they didn't appear to work with theIMPORTED_LOCATIONproperty.