-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warning #1312
Merged
cary-ilm
merged 1 commit into
AcademySoftwareFoundation:main
from
reunanen:fix-compiler-warning
Nov 12, 2022
Merged
Fix compiler warning #1312
cary-ilm
merged 1 commit into
AcademySoftwareFoundation:main
from
reunanen:fix-compiler-warning
Nov 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unsigned int', possible loss of data Solution: add explicit typecasting Signed-off-by: Juha Reunanen <juha.reunanen@tomaattinen.com>
reunanen
force-pushed
the
fix-compiler-warning
branch
from
November 10, 2022 14:54
d187af3
to
df3177f
Compare
cary-ilm
requested changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. One small note above about the assert.
reunanen
force-pushed
the
fix-compiler-warning
branch
from
November 11, 2022 18:24
df3177f
to
5d39e65
Compare
cary-ilm
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
…unsigned int', possible loss of data (AcademySoftwareFoundation#1312) Solution: add explicit typecasting Signed-off-by: Juha Reunanen <juha.reunanen@tomaattinen.com> Signed-off-by: Juha Reunanen <juha.reunanen@tomaattinen.com>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
…unsigned int', possible loss of data (#1312) Solution: add explicit typecasting Signed-off-by: Juha Reunanen <juha.reunanen@tomaattinen.com> Signed-off-by: Juha Reunanen <juha.reunanen@tomaattinen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert
that a value being converted tounsigned int
is not negative