-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend multipart RgbaInputFile API #1201
Extend multipart RgbaInputFile API #1201
Conversation
Signed-off-by: Balazs OROSZI <orobalage@gmail.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
This all looks fine to me, but is it worth adding a reference to this in the documentation, since it's new functionality? |
It is worth documenting, yes. I don't see any documentation of |
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* RgbaInputFile: Multipart support test Signed-off-by: Balazs OROSZI <orobalage@gmail.com> * extend multipart RgbaInputFile API Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * remove RgbaInputFile friend from MultiPartInputFile Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * fix test failure: test all parts for completion Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * add missing export to ImfRgbaFile.h Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * add multipart Rgba support to Imf::CheckFile Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> Co-authored-by: Balazs OROSZI <orobalage@gmail.com>
Extends #1194 with more functionality for reading multipart files using RgbaInputFile:
I'm not 100% sure that MultiPartInputFile + InputPart handles weird edge cases identically to InputFile, so some semi-broken files may be handled differently.