reduce iterations in testIDManifest to speed up #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
meshula
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
I've never liked this test. If the random seed is always the same, it's not really random, it'll be the same sequence of random entries. Testing the same set of 1000 words year after year really doesn't feel like it's telling us anything at all, except that the sequence is fine. (We are reseeding an LCG generator, std::default_random_generator, with the same value). It seems to me like we should be deliberately checking a small number of edge cases and deliberately constructed "could fail" tests. Otherwise what's the point of this long running test?
Short of rewriting this test, shortening the test sure gets my vote.
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Oct 21, 2021
…ation#1180) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
that referenced
this pull request
Oct 24, 2021
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testIDManifest was timing out on slow processors due to 1500 second test limit.
This change runs 20 different random manifests instead of 100 to speed it up. On Raspberry Pi with ARM7 architecture, testIDManifest now completes in around 500 seconds. (Slowest test is now testHuf, at just over 1000s)
Signed-off-by: Peter Hillman peterh@wetafx.co.nz