Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak when parsing header with duplicate attribute names #1157

Merged

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Sep 25, 2021

Fixes OSS Fuzz 39206

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
while parsing a header, if someone has injected a duplicate attribute
name as an attack vector, fix memory leak for certain attribute types

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdt3rd kdt3rd merged commit 54075eb into AcademySoftwareFoundation:master Sep 25, 2021
@kdt3rd kdt3rd deleted the fix_duplicate_attr_name_leak branch September 25, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants