CMAKE_CROSSCOMPILING_EMULATOR and misc. fixes

[patlefort]

Fix a few problems that I noticed and some mingw related problems.

• Fix a few formatting problems.
• Fix for -Wformat-security warnings in internal_win32_file_impl.h for mingw and also for security.
• In unpack.c: Add missing <stdbool.h> include.
• Swap intrinsic include check. On mingw both files are present but intrin.h should be used.
• Disable a warning only for MSVC.
• Remove useless export on defaulted destructor. Mingw doesn't like it.
• Add CMAKE_CROSSCOMPILING_EMULATOR for all tests. This allows running tests on a platform like mingw.

Signed-off-by: Patrick Northon northon_patrick3@yahoo.ca

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ patlefort (b579b6a)

[meshula]

Thanks for the contribution, it all looks good, but could I ask for a little bit of documentation as noted in the review?

[patlefort]

I added some comments about CMAKE_CROSSCOMPILING_EMULATOR. I also did for commented out tests just in case.

[patlefort]

I notice that while my intrin.h change fix mingw, it break clang. I don't know why it tries to do #include_next <intrin.h> on anything else than MSVC because then nobody can check for the presence of intrin.h for intrinsics support.
My proposition:

#ifdef __has_include
#    if defined(_WIN32) && __has_include(<intrin.h>)
#        include <intrin.h>
#    elif defined(__x86_64__) && __has_include(<x86intrin.h>)
#        include <x86intrin.h>
#    endif
#endif

[cary-ilm]

Since the bulk of this PR is the CMAKE_CROSSCOMPILING_EMULATOR support, it will be better to have that in the title.

[meshula]

I think this all looks good now?

[cary-ilm]

LGTM, too, thanks!

[hjmallon]

You only need the CMAKE_CROSSCOMPILING_EMULATOR here because of the way the tests are called. If you replace $<TARGET_FILE:OpenEXRUtilTest>, with just OpenEXRUtilTest (for cmake executable targets) then cmake recognises them and this should all happen transparently.

i.e.

add_test(NAME OpenEXRCore.${curtest} COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:OpenEXRCoreTest> ${curtest})

becomes

add_test(NAME OpenEXRCore.${curtest} COMMAND OpenEXRCoreTest ${curtest})