Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel build: Fix download hash for Imath #1078

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Bazel build: Fix download hash for Imath #1078

merged 1 commit into from
Jun 30, 2021

Conversation

Vertexwahn
Copy link
Contributor

This PR only affects the Bazel Build:

  • The download hash for Imath is incorrect. This PR fixes it

@Vertexwahn
Bazel build: Fix download hash for Imath
fc29324 
Signed-off-by: Vertexwahn <julian.amann@tum.de>
cary-ilm
cary-ilm approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm
Copy link
Member

Thanks. For future reference, where are you pulling this hash? I assumed it was the commit sha at the release tag.

@cary-ilm cary-ilm merged commit 44d2d0e into AcademySoftwareFoundation:RB-3.0 Jun 30, 2021
@Vertexwahn
Copy link
Contributor Author 

curl -sL https://github.com/AcademySoftwareFoundation/Imath/archive/refs/tags/v3.0.5.tar.gz --output Imath-3.0.5.tar.gz
sha256sum Imath-3.0.5.tar.gz

@Vertexwahn Vertexwahn deleted the fix-imath-sha256-for-bazel-build branch June 30, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees
No one assigned
Labels
v3.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vertexwahn @cary-ilm