Refactor deep tests to separate file, fix deep chunk reads, ripmap reading #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ading Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
cary-ilm
reviewed
Jun 28, 2021
src/lib/OpenEXRCore/unpack.c
Outdated
| @@ -992,6 +995,186 @@ generic_unpack (exr_decode_pipeline_t* decode) | |||
| return EXR_ERR_SUCCESS; | |||
| } | |||
|
|
|||
| //static exr_result_t | |||
There was a problem hiding this comment.
Should this commented-out code be removed altogether?
cary-ilm
reviewed
Jun 28, 2021
src/lib/OpenEXRCore/unpack.c
Outdated
| @@ -1017,7 +1200,8 @@ internal_exr_match_decode ( | |||
| init_cpu_check = 0; | |||
| } | |||
|
|
|||
| /* TODO */ | |||
| /* we don't decode deep for now, it is up to the user to do that (for efficiency) */ | |||
| //if (isdeep) return &generic_unpack_deep; | |||
There was a problem hiding this comment.
Should this commented-out line be removed?
cary-ilm
approved these changes
Jun 28, 2021
|
I was misinterpreting the data coming in, which is why I had disabled this thinking I would limit scope. But after talking to Peter today, I think I will uncomment it shortly and provide that again |
- add safety check to zip - fix piz decompressor - add optimization for unpack - fix pointer deep read - reenable deep decoding Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kimball Thurston kdt3rd@gmail.com