Skip to content

Commit

Permalink
Merge branch 'master' into headertestfixes
Browse files Browse the repository at this point in the history
  • Loading branch information
peterhillman authored Jan 24, 2020
2 parents 64428ee + 8f43dd5 commit 3c3e1b0
Show file tree
Hide file tree
Showing 8 changed files with 65 additions and 17 deletions.
40 changes: 40 additions & 0 deletions ASWF/tsc-meetings/2019-11-21.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# 11/21/2019

### Attending:

* Cary Phillips
* Christina Tempelaar-Lietz
* Peter Hillman
* Nick Porcino
* Larry Gritz

### Discussion:

* The repo has moved. All seems to have gone smoothly.

* Looks like azure pipeline needs to be set up in the new org. PR’s
are not currently triggering builds.

* Larry asked about GitHub merge policy. “Allow squash merging” has
now been turned on.

* Imath repo: Let’s begin with a very simple example of pybind11, then
add to it gradually.

* Nick: We should remove ImathRandom from Imath, and rely on C++11
random. But this will require careful testing.

* #484 - the “-x” option to limit memory usage: not worth the
complexity. We considered this back when we were questioning how to
deal with security vulnerabilities, but none of us feel that this is
a necessary feature, or one that adequately addresses a security
issue.

* #591 - pthread support for mingw: PR needs serious cleanup, not
acceptable in its current form.

* #215 - uninstall target: good enough idea, but we’d like a “dry run”
option.

* #344 - new DwaCompressor setting. Should be a part of a performance
metric suite.
7 changes: 3 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,24 +105,23 @@ can be merged.

* If you are an individual writing the code on your own time and
you're SURE you are the sole owner of any intellectual property you
contribute, you can [signing the CLA as an individual contributor](https://github.com/communitybridge/easycla/blob/master/docs/sign-a-cla-as-an-individual-contributor-to-github.md).
contribute, you can [sign the CLA as an individual contributor](https://github.com/communitybridge/easycla/blob/master/docs/sign-a-cla-as-an-individual-contributor-to-github.md).

* If you are writing the code as part of your job, or if there is any
possibility that your employers might think they own any
intellectual property you create, then you should use the [Corporate
Contributor Licence
Agreement](https://github.com/communitybridge/easycla/blob/master/docs/contribute-to-a-github-company-project.md).

The OpenEXR CLA's are the standard forms used by Linux Foundation
The OpenEXR CLAs are the standard forms used by Linux Foundation
projects and [recommended by the ASWF TAC](https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#contributor-license-agreement-cla).

### Commit Sign-Off

Every commit must be signed off. That is, every commit log message
must include a “`Signed-off-by`” line (generated, for example, with
`git commit --signoff`”), indicating that the committer wrote the
code and has the right to release it under the
[Modified-BSD-3-Clause](https://opensource.org/licenses/BSD-3-Clause)
code and has the right to release it under the [BSD-3-Clause](LICENSE.md)
license. See https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#contribution-sign-off for more information on this requirement.

## Development Workflow
Expand Down
11 changes: 9 additions & 2 deletions OpenEXR/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ include(config/LibraryDefine.cmake)

add_subdirectory( IlmImf )
add_subdirectory( IlmImfUtil )
add_subdirectory( IlmImfExamples )

option(INSTALL_OPENEXR_EXAMPLES "Install OpenEXR examples" ON)
if(INSTALL_OPENEXR_EXAMPLES)
add_subdirectory( IlmImfExamples )
endif()

##########################
# Tests
Expand Down Expand Up @@ -78,4 +82,7 @@ if(OPENEXR_BUILD_UTILS)
add_subdirectory( exrmultipart )
endif()

add_subdirectory(doc)
option(INSTALL_OPENEXR_DOCS "Install OpenEXR documentation" ON)
if(INSTALL_OPENEXR_DOCS)
add_subdirectory(doc)
endif()
1 change: 1 addition & 0 deletions OpenEXR/IlmImf/ImfCRgbaFile.h
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,7 @@ int ImfTiledOutputLevelRoundingMode
struct ImfInputFile;
typedef struct ImfInputFile ImfInputFile;

IMF_EXPORT
ImfInputFile * ImfOpenInputFile (const char name[]);

IMF_EXPORT
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[![License](https://img.shields.io/badge/License-BSD%203%20Clause-blue.svg)](LICENSE.md)
[![License](https://img.shields.io/github/license/AcademySoftwareFoundation/openexr)](LICENSE.md)
[![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/2799/badge)](https://bestpractices.coreinfrastructure.org/projects/2799)
[![Build Status](https://dev.azure.com/openexr/OpenEXR/_apis/build/status/openexr.openexr?branchName=master)](https://dev.azure.com/openexr/OpenEXR/_build/latest?definitionId=1&branchName=master)
[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=openexr_openexr&metric=alert_status)](https://sonarcloud.io/dashboard?id=openexr_openexr)
[![Build Status](https://dev.azure.com/academysoftwarefoundation/Academy%20Software%20Foundation/_apis/build/status/academysoftwarefoundation.openexr)](https://dev.azure.com/academysoftwarefoundation/Academy%20Software%20Foundation/_build?definitionId=4&_a=summary)
[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=AcademySoftwareFoundation_openexr&metric=alert_status)](https://sonarcloud.io/dashboard?id=AcademySoftwareFoundation_openexr)

# OpenEXR

Expand Down Expand Up @@ -98,7 +98,7 @@ package.

### OpenEXR Project Goverance

OpenEXR is governed by the Academy Software Foundation. See
OpenEXR is hosted by the Academy Software Foundation. See
[GOVERNANCE](GOVERNANCE.md) for more infomation about how the project
operates.

Expand Down
3 changes: 3 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ schedules:
- master
always: true

variables:
- group: sonar

jobs:
# ------------------------------------------------------------------------------
# Linux
Expand Down
4 changes: 1 addition & 3 deletions share/ci/templates/build_sonar.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,5 @@ steps:
- bash: share/ci/scripts/linux/run_gcov.sh
displayName: Generate code coverage report

- bash: sonar-scanner -X -Dsonar.login=$SONAR_TOKEN
env:
SONAR_TOKEN: $(tokens.sonarCloud)
- bash: sonar-scanner -X -Dsonar.login=$(SONAR_TOKEN)
displayName: Run sonar-scanner
8 changes: 4 additions & 4 deletions sonar-project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
sonar.host.url=https://sonarcloud.io

# Required metadata
sonar.organization=openexr-github
sonar.projectKey=openexr_openexr
sonar.organization=academysoftwarefoundation
sonar.projectKey=AcademySoftwareFoundation_openexr
sonar.projectName=OpenEXR
sonar.projectVersion=2.3
sonar.projectVersion=2.4

# Project links
sonar.links.homepage=http://openexr.com
sonar.links.ci=https://dev.azure.com/OpenEXR/_build
sonar.links.ci=https://dev.azure.com/academysoftwarefoundation/Academy%20Software%20Foundation/_build?definitionId=4&_a=summary
sonar.links.scm=https://github.com/AcademySoftwareFoundation/openexr
sonar.links.issue=https://github.com/AcademySoftwareFoundation/openexr/issues

Expand Down

0 comments on commit 3c3e1b0

Please sign in to comment.