Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing cppunit and re-sorted packages #51

Merged

Conversation

aloysbaillet
Copy link
Contributor

@aloysbaillet aloysbaillet commented May 16, 2020

There was a missing COPY for cppunit, and I re-ordered the other packages in the same order as the FROM to try to reduce this kind of mistakes.

Fixes #50

I also had to update pip packages (pipenv update) to fix a mypy issue.

Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com>
Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com>
Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com>
Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com>
Copy link
Contributor

@jfpanisset jfpanisset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aloysbaillet aloysbaillet merged commit cf8c557 into AcademySoftwareFoundation:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cppunit missing from vfxall
2 participants