all children of EDL are outside of track range #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDL adapter was creating massively negative start time source ranges on tracks, which caused all children to be trimmed (so trimmed_range_in_parent() always returned None).
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
===========================================
- Coverage 87.15% 73.81% -13.35%
===========================================
Files 67 59 -8
Lines 6734 5350 -1384
===========================================
- Hits 5869 3949 -1920
- Misses 865 1401 +536
Continue to review full report at Codecov.
|
reinecke
changed the title
|
We don't think this will correctly address the issue. To be solved with a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source range of a track coming from the EDL adapter has a negative start time, so all children are out of trimmed out of range. This was an attempt at fixing #346.