Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Version TextureOptBatch like we did for TextureOpt #4490

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Oct 14, 2024

I got part way through the OSL side changes to accommodate what we did
recently with TextureOpt and TextureOptBatch. Ugh, it's a lot harder than
I thought and I don't know how to finish the job without postponing the
3.0 release even more, which is unacceptable at this point. So here I do
to TextureOptBatch to get out of this mess:

  • "Version" TextureOptBatch like we did for TextureOpt (should have done
    that all along).
  • Revert "v1" to the same byte-for-byte layout we used to have, which
    involves using int for some fields as it implicitly did before, because
    the new enum classes totally change the field sizes and struct layout.
  • Sketch out in comments what v2 might look like, to more fully match the
    TextureOpt. The introduction of struct versioning means we can make that
    change for 3.1, it doesn't need to wait years for 4.0.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented Oct 15, 2024

In the interests of trying to get a 3.0 beta out the door today, I'm going to merge this. Hopefully it is fine with everybody, and if not, we can tweak it during the beta period if necessary.

@lgritz lgritz merged commit d36e615 into AcademySoftwareFoundation:dev-3.0 Oct 15, 2024
28 of 29 checks passed
@lgritz lgritz deleted the lg-tex branch October 15, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant