fix: Update INSTALL.md for windows #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small adjustment to expected paths for the manual instructions. Signed-off-by: Mel Massadian <melmassadian@gmail.com>
The committers listed above are authorized under a signed CLA. |
lgritz
approved these changes
May 31, 2024
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jun 24, 2024
While making a CI to build python wheels for OIIO on windows I spotted a few issues in the instructions, these edits made it work for me. Small adjustment to expected paths for the manual instructions. Signed-off-by: Mel Massadian <melmassadian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making a CI to build python wheels for OIIO on windows I spotted a few issues in the instructions, these edits made it work for me.
Description
Small adjustment to expected paths for the manual instructions.
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.