Skip to content

Commit

Permalink
ci: Run wheel workflow on certain pushes (#4617)
Browse files Browse the repository at this point in the history
We were only running the wheel workflow on pushes of TAGS, but this
change also will run it when we push to release, and dev-3.* branches.

My usual release workflow is to first push the "release" branch, watch
for it to pass CI, then add the tag and push the tag and draft the
release. If a problem with the wheel workflow isn't discovered until
we've already pushed the tag, then a fix will require a new tag and new
release (we never re-tag a release). So this change will allow us to
catch any problems with the wheel worflow BEFORE we actually irrevocably
make the tag, since it's no big deal to add corrections to the branch
before tagging. It still won't upload the wheels until the tag itself is
pushed.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
  • Loading branch information
lgritz authored Feb 2, 2025
1 parent 72c84c8 commit 1ca8406
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@ permissions:

on:
push:
# Workflow run on tags for v3 only.
# Workflow run on tags for v3 only, or pre-tagged pushes of release, or
# dev-3.* branches.
tags:
- v3.*
branches:
- release
- dev-3.*
pull_request:
# Workflow run on pull_request only when related files change.
paths:
Expand Down

0 comments on commit 1ca8406

Please sign in to comment.