Adsk Contrib - Change default C++ version to 14 #1508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Signed-off-by: hodoulp <Patrick.Hodoul@autodesk.com>
|
@hodoulp I think the CI error is due to the originating branch being in the main OCIO repo instead of your fork. In a fork, the GPU CI will be blocked on push. |
michdolan
reviewed
Oct 4, 2021
Co-authored-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
force-pushed
the
adsk_contrib/change_cpp_version
branch
from
7367989
to
9440b8d
Compare
|
@michdolan Do you think I should redo my pull request (i.e. no workaround) ? |
|
I will recreate the pull request from a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Hodoul Patrick.Hodoul@autodesk.com
As discussed at the last TSC meeting, the versions of
OpenImageIOandOpenShadingLanguagelibraries for CY2022 do not anymore support C++11. To avoid problem to occasional contributors and package maintainers, the default C++ version is now 14 (but CI builds still compile 11, 14, 17 to guaranty support).I also changed a little bit the various CI builds to better cover the three supported C++ versions on all platforms for CY2022 & CY2021.