Fixed off-by-one index check in setChildIndex #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the existing test case: valid values for `index` in the test case are `0` and `1` only. Minimal repro via Python bindings: ```bash $ python3 -c 'import MaterialX as mx; d = mx.createDocument(); b = d.addBackdrop(); d.setChildIndex(b.getName(), 1)' ``` Without this patch: ```bash Segmentation fault ``` With this patch: ```python Traceback (most recent call last): File "<string>", line 1, in <module> LookupError: Invalid child index ``` Ran the tests locally via `make && make test`: ```bash 100% tests passed, 0 tests failed out of 73 ``` Update AcademySoftwareFoundation#1581 Signed-off-by: Stefan Habel <19556655+StefanHabel@users.noreply.github.com>
jstone-lucasfilm
approved these changes
Oct 24, 2023
jstone-lucasfilm
changed the title
Element::setChildIndex().
jstone-lucasfilm
merged commit a5b832d
into
AcademySoftwareFoundation:main
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the existing test case:
valid values for
indexin the test case are0and1only.Minimal repro via Python bindings:
$ python3 -c 'import MaterialX as mx; d = mx.createDocument(); b = d.addBackdrop(); d.setChildIndex(b.getName(), 1)'Without this patch:
With this patch:
Ran the tests locally via
make && make test:Update #1581