Improvements to GGX importance sampling #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement the paper "Sampling Visible GGX Normals with Spherical Caps" by Jonathan Dupuy and Anis Benyoub, which improves the performance and spatial continuity of VNDF sampling. - Switch to VNDF sampling for FIS environment lights, improving the convergence of this lighting path for lower sample counts. - Additional optimizations for FIS environment lights, leveraging the improved term cancellation in VNDF sampling. Test results: - GLSL render performance is improved for all tested materials, e.g. an increase from 205 fps to 214 fps for standard_surface_default.mtlx with 16 environment samples on an NVIDIA RTX A6000. - Convergence of FIS environment lights is improved for all tested materials, with the maximum visual error between 16 and 4096 environment samples reduced from 0.11 to 0.07 for a rough gold material.
|
Adding some render comparisons and statistics: Original Filtered Importance Sampling (16 samples / 16384 samples / difference image) New Filtered Importance Sampling (16 samples / 16384 samples / difference image) |
|
And here are the latest render comparisons between GLSL and OSL: |
|
Looks good, thanks for getting this in! 👍 |
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
- Implement the paper "Sampling Visible GGX Normals with Spherical Caps" by Jonathan Dupuy and Anis Benyoub, which improves the performance and spatial continuity of VNDF sampling. - Switch to VNDF sampling for FIS environment lights, improving the convergence of this lighting path for lower sample counts. - Additional optimizations for FIS environment lights, leveraging the improved term cancellation in VNDF sampling. Test results: - GLSL render performance is improved for all tested materials, e.g. an increase from 205 fps to 214 fps for standard_surface_default.mtlx with 16 environment samples on an NVIDIA RTX A6000. - Convergence of FIS environment lights is improved for all tested materials, with the maximum visual error between 16 and 16384 environment samples reduced from 0.1098 to 0.0745 for a rough gold material.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test results: