Skip to content

Commit

Permalink
Always build GLFW as a static library (#1680)
Browse files Browse the repository at this point in the history
Currently the embedded glfw build for MaterialXGraphEditor inherits the value of BUILD_SHARED_LIBS from MATERIALX_BUILD_SHARED_LIBS, but we're not installing libglfw, per #1245 the intention was to statically link.
  • Loading branch information
ld-kerley authored Jan 30, 2024
1 parent d1e08f3 commit 8828578
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions source/MaterialXGraphEditor/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ set(GLFW_BUILD_TESTS OFF)
set(GLFW_BUILD_DOCS OFF)
set(GLFW_INSTALL OFF)

# Explicitly build GLFW with static libraries, independent of the broader build settings.
set(BUILD_SHARED_LIBS OFF)

add_subdirectory(External/Glfw)

if(MSVC)
Expand Down

0 comments on commit 8828578

Please sign in to comment.