Test return value of extractSHRT to avoid uninitialized reference #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If extractSHRT failes in computeRSMatrix, it's an error, so throw. If extractSHRT fails in testMatrix in testExtractSHRT.cpp, it's fatal. The test was present for testMatrix(M33f) but missing for testMatrix(M44f). This lead to an uninitialized memory refererence since the failure leaves the arguments uninitialized. Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Jun 2, 2022
|
Yes, I noted the same thing. For consistency, adding that might be a preferable solution, but at this point it's probably best to just leave the API as is. It's a pretty obscure function, I doubt it's used widely. |
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Oct 31, 2022
…ademySoftwareFoundation#261) If extractSHRT failes in computeRSMatrix, it's an error, so throw. If extractSHRT fails in testMatrix in testExtractSHRT.cpp, it's fatal. The test was present for testMatrix(M33f) but missing for testMatrix(M44f). This lead to an uninitialized memory refererence since the failure leaves the arguments uninitialized. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Nov 3, 2022
If extractSHRT failes in computeRSMatrix, it's an error, so throw. If extractSHRT fails in testMatrix in testExtractSHRT.cpp, it's fatal. The test was present for testMatrix(M33f) but missing for testMatrix(M44f). This lead to an uninitialized memory refererence since the failure leaves the arguments uninitialized. Signed-off-by: Cary Phillips <cary@ilm.com>
This was referenced Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If extractSHRT failes in computeRSMatrix, it's an error, so throw.
If extractSHRT fails in testMatrix in testExtractSHRT.cpp, it's fatal. The test was present for testMatrix(M33f) but missing for testMatrix(M44f). This lead to an uninitialized memory refererence since the failure leaves the arguments uninitialized.
Signed-off-by: Cary Phillips cary@ilm.com