Nicolas/orc 176 remove response generic in stargate commit any #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cw-orchestrator with
|
| Latest commit: |
5c1f74d
|
| Status: | ⚡️ Build in progress... |
Kayanski
changed the base branch from
main
to
buckram/revive-osmosis-test-tube
…remove-response-generic-in-stargatecommit_any
Buckram123
approved these changes
Oct 25, 2024
| @@ -381,27 +379,34 @@ impl BankSetter for OsmosisTestTube { | |||
| } | |||
|
|
|||
| impl Stargate for OsmosisTestTube { | |||
| fn commit_any<R: prost::Message + Default>( | |||
| fn commit_any( | |||
There was a problem hiding this comment.
Doable for neutron as well, yeah?
…remove-response-generic-in-stargatecommit_any
Kayanski
merged commit 44b2b5c
into
buckram/revive-osmosis-test-tube
9 of 12 checks passed
Kayanski
deleted the
nicolas/orc-176-remove-response-generic-in-stargatecommit_any
branch
Kayanski
added a commit
that referenced
this pull request
Oct 25, 2024
* new osmosis tube * enable neutron test tube * clippy * instantiate2 for osmosis test tube * migrate for osmosis test tube * migrate fix * Fixed doc tests * migrate+instantiate2 for neutron * coin sorting * Nicolas/orc 176 remove response generic in stargate commit any (#512) * Removed generic parameter * Features fix * Warning * Published all versions for breaking change --------- Co-authored-by: Kayanski <kowalski.kowalskin@gmail.com> Co-authored-by: Kayanski <44806566+Kayanski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr aims at removing the response generic in cw-orch-traits::Stargate trait
Checklist