Added upload_with_access #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cw-orchestrator with
|
| Latest commit: |
93f00d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba61a75e.cw-orchestrator.pages.dev |
| Branch Preview URL: | https://nicolas-orc-165-add-possibil.cw-orchestrator.pages.dev |
Buckram123
approved these changes
Sep 9, 2024
Buckram123
approved these changes
Sep 9, 2024
…-the-instantiate-permissions-on
CyberHoward
reviewed
Sep 9, 2024
CyberHoward
reviewed
Sep 9, 2024
cw-orch-daemon/src/core.rs
Outdated
| instantiate_permission: None, | ||
| instantiate_permission: access | ||
| .map(|a| { | ||
| let response = match a { |
There was a problem hiding this comment.
Move this into a try_into implementation?
There was a problem hiding this comment.
That's not possible because AccessConfig is defined in cw-orch-core and cosmrs is not a dependency of the core crate. Moved that behavior to a function for beter readability
Kayanski
deleted the
nicolas/orc-165-add-possibility-to-configure-the-instantiate-permissions-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at allowing users to upload cosmwasm contracts with instantiate permission settings.
Checklist