Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicolas/orc 136 list of attribute values #411

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Jun 7, 2024

This Pr aims at adding event_attr_values function to IndexResponse to get all the attributes to a value.

The trait provides a default implementation to avoid breaking changes to cw-orch-core

Checklist

  • Changelog updated.
  • Docs updated.

Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9868388
Status: ✅  Deploy successful!
Preview URL: https://8b608940.cw-orchestrator.pages.dev
Branch Preview URL: https://nicolas-orc-136-list-of-attr.cw-orchestrator.pages.dev

View logs

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 56.5%. Comparing base (7d28f5b) to head (9868388).

Additional details and impacted files
Files Coverage Δ
cw-orch-daemon/src/tx_resp.rs 82.6% <0.0%> (-5.1%) ⬇️
packages/clone-testing/src/core.rs 82.5% <0.0%> (-2.1%) ⬇️
...ges/cw-orch-core/src/environment/index_response.rs 73.1% <0.0%> (-10.9%) ⬇️
packages/interchain/interchain-core/src/types.rs 3.8% <0.0%> (-0.9%) ⬇️

Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kayanski Kayanski merged commit 67e9556 into main Jun 11, 2024
17 of 18 checks passed
@Kayanski Kayanski deleted the nicolas/orc-136-list-of-attribute-values branch June 11, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants