Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Execute and Query derive Macros #398

Merged
merged 10 commits into from
Jun 4, 2024
Merged

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented May 17, 2024

This PR aims at removing duplicate code and merges execute and query msgs.

Tasks done

  • Merges query and Execute derive functions
  • Rationalized the macros in order to fully use syn instead of home-made functions and manipulations
    --> This was done to be able to better support generics in the future.

Depends on #389

Copy link

cloudflare-workers-and-pages bot commented May 17, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 60ac278
Status:⚡️  Build in progress...

View logs

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.5%. Comparing base (2145024) to head (60ac278).
Report is 1 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
packages/cw-orch-fns-derive/src/execute_fns.rs 100.0% <100.0%> (+0.6%) ⬆️
packages/cw-orch-fns-derive/src/fns_derive.rs 100.0% <100.0%> (ø)
packages/cw-orch-fns-derive/src/helpers.rs 73.1% <ø> (-1.1%) ⬇️
packages/cw-orch-fns-derive/src/lib.rs 100.0% <100.0%> (ø)
packages/cw-orch-fns-derive/src/query_fns.rs 100.0% <100.0%> (+4.5%) ⬆️

@Kayanski Kayanski requested review from Buckram123 and CyberHoward and removed request for Buckram123 June 3, 2024 09:58
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kayanski Kayanski merged commit cf5c678 into main Jun 4, 2024
17 of 18 checks passed
@Kayanski Kayanski deleted the update/merge-ex-qu-derive-fns branch June 4, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants