Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ibc-chain-registry #375

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Removed ibc-chain-registry #375

merged 2 commits into from
Apr 24, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Apr 23, 2024

This PR aims at removing the ibc-chain-registry dependency from cw-orch networks.
We now use our own ChainInfo types and get rid of this huge dependency

Sort of closes ORC-119

@Kayanski Kayanski requested a review from CyberHoward April 23, 2024 09:33
Copy link

cloudflare-workers-and-pages bot commented Apr 23, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: d4d8cc8
Status: ✅  Deploy successful!
Preview URL: https://26498f7b.cw-orchestrator.pages.dev
Branch Preview URL: https://update-remove-ibc-relayer-ty.cw-orchestrator.pages.dev

View logs

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.5%. Comparing base (994053c) to head (d4d8cc8).

Additional details and impacted files
Files Coverage Δ
cw-orch-daemon/src/builder.rs 62.9% <100.0%> (ø)
cw-orch-daemon/src/channel.rs 82.9% <100.0%> (ø)
cw-orch-daemon/src/live_mock.rs 51.2% <100.0%> (ø)
cw-orch-daemon/src/sender.rs 58.8% <100.0%> (-0.8%) ⬇️
cw-orch-daemon/src/state.rs 88.8% <100.0%> (ø)
cw-orch-daemon/src/sync/builder.rs 86.8% <100.0%> (-4.3%) ⬇️
packages/cw-orch-networks/src/chain_info.rs 62.0% <100.0%> (-22.8%) ⬇️
cw-orch-daemon/src/queriers/env.rs 0.0% <0.0%> (ø)

@Kayanski Kayanski mentioned this pull request Apr 23, 2024
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to use our types instead of chain registry types. Will try to figure out another way to find explorer urls for CLI 😜

packages/cw-orch-networks/src/chain_info.rs Outdated Show resolved Hide resolved
packages/cw-orch-networks/src/chain_info.rs Outdated Show resolved Hide resolved
@Kayanski Kayanski merged commit 31c160c into main Apr 24, 2024
18 checks passed
@Kayanski Kayanski deleted the update/remove-ibc-relayer-types branch April 24, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants