Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs custom CosmTxResponse instead of raw TxResponse #363

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Apr 8, 2024

This PR aims at avoiding to log un-necessary information when debug-logging.
It just logs the parsed CosmTxResponse instead of the raw TxResponse

@Kayanski Kayanski requested a review from CyberHoward April 8, 2024 18:55
Copy link

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb99399
Status: ✅  Deploy successful!
Preview URL: https://4a1f75f4.cw-orchestrator.pages.dev
Branch Preview URL: https://nicolas-orc-106-remove-binar.cw-orchestrator.pages.dev

View logs

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.7%. Comparing base (ff1e75d) to head (fb99399).

Additional details and impacted files
Files Coverage Δ
cw-orch-daemon/src/queriers/node.rs 44.6% <100.0%> (ø)

@CyberHoward
Copy link
Contributor

Did you confirm that this stopped the bin blob to be logged on upload?

@Kayanski
Copy link
Contributor Author

Kayanski commented Apr 9, 2024

Did you confirm that this stopped the bin blob to be logged on upload?

Yes !

@CyberHoward CyberHoward merged commit ab461e6 into main Apr 9, 2024
17 of 18 checks passed
@CyberHoward CyberHoward deleted the nicolas/orc-106-remove-binary-print-on-upload branch April 9, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants