Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicolas/orc 67 no way to set hd index #306

Merged
merged 31 commits into from
Feb 1, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Jan 12, 2024

This PR aims at introducing index modifications on the sender object.
Depends on #305

Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71f4614
Status:⚡️  Build in progress...

View logs

@Kayanski Kayanski requested a review from Buckram123 January 15, 2024 16:14
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kayanski Kayanski requested a review from CyberHoward January 23, 2024 09:19
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you need this?

The hd index is like a derivation sequence right? So you can create multiple wallets from the same private key?

@Kayanski
Copy link
Contributor Author

Kayanski commented Jan 23, 2024

Is there a reason why you need this?

The hd index is like a derivation sequence right? So you can create multiple wallets from the same private key?

You can create multiple wallets from the same mnemonic yes ! It was a request from @Buckram123
Something to do with Starship I think.

@Buckram123
Copy link
Contributor

Is there a reason why you need this?

For example this signer: https://github.com/cosmology-tech/starship/blob/5dcc918dc7d87a713bcde684293f5cdf5df1c63c/charts/devnet/scripts/neutron/create-neutron-genesis.sh#L45-L47

I have mnemonic, but have no way to sign it using cw-orch

@CyberHoward
Copy link
Contributor

LGTM!

Base automatically changed from feature/add-authz-wrapping to main January 29, 2024 13:04
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a990cbe) 66.2% compared to head (344acd9) 66.2%.
Report is 1 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
cw-orch-daemon/src/sync/builder.rs 70.7% <100.0%> (+3.1%) ⬆️
cw-orch-daemon/src/builder.rs 63.4% <0.0%> (-4.4%) ⬇️
cw-orch-daemon/src/sender.rs 61.7% <50.0%> (-0.8%) ⬇️

@Kayanski Kayanski merged commit f39ab04 into main Feb 1, 2024
7 of 8 checks passed
@Kayanski Kayanski deleted the nicolas/orc-67-no-way-to-set-hd-index branch February 1, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants